Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed text alignment and icon logic #43876

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

emoral435
Copy link
Contributor

Summary

  1. Previously, for every breadcrumb, we where loading an icon alongside its text. Because we where using NcButton, this meant that the button was trying to load an icon and its accompanying text, splitting the button width into two, which is why the padding looked funky!
  2. The icon rendering logic now needs to change in order to fit the new NcBreadcrumb logic, so we serve the component an icon that we use now instead of having it on every section!

Unrelated, but while testing this, it seems that the uploading section of this component seems to block the view of the breadcrumbs even when you are not uploading something. May have to do with our upload stores queue not updating correctly? Will test later!

Screenshots of the new change

SCR-20240227-jtcg

Checklist

@emoral435 emoral435 self-assigned this Feb 27, 2024
@emoral435 emoral435 force-pushed the fix/breadcrumbs/fix-misaligned-text branch from abd9f86 to fbce6af Compare February 27, 2024 16:53
@emoral435 emoral435 marked this pull request as ready for review February 27, 2024 17:15
@emoral435 emoral435 force-pushed the fix/breadcrumbs/fix-misaligned-text branch from fbce6af to 28da105 Compare February 28, 2024 01:38
@emoral435 emoral435 force-pushed the fix/breadcrumbs/fix-misaligned-text branch from 28da105 to fd12b13 Compare February 28, 2024 15:25
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now :)

@skjnldsv
Copy link
Member

/backport to stable28

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews backport-request labels Feb 28, 2024
@skjnldsv
Copy link
Member

conflicts 🙈

Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the fix/breadcrumbs/fix-misaligned-text branch from fd12b13 to 2b4ec59 Compare February 29, 2024 13:03
@emoral435
Copy link
Contributor Author

Fixed 🐘

@skjnldsv

This comment was marked as resolved.

@emoral435 emoral435 merged commit 1feb4f1 into master Feb 29, 2024
98 checks passed
@emoral435 emoral435 deleted the fix/breadcrumbs/fix-misaligned-text branch February 29, 2024 14:52
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Padded breadcrumbs
3 participants